Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: inputnumber handler inner center #24266

Merged
merged 1 commit into from May 19, 2020
Merged

fix: inputnumber handler inner center #24266

merged 1 commit into from May 19, 2020

Conversation

xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented May 18, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #24076

💡 Background and solution

感觉上 好了一点 😂😂😂

📝 Changelog

Language Changelog
🇺🇸 English Fix InputNumber handler style of center
🇨🇳 Chinese 修复 InputNumber 操作按钮居中样式

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@xrkffgg
Copy link
Member Author

xrkffgg commented May 18, 2020

没带本子，明天看一下 mac 的效果。

@ant-design-bot
Copy link
Contributor

ant-design-bot commented May 18, 2020 •
edited

@codecov
Copy link

codecov bot commented May 18, 2020 •
edited

Codecov Report

Merging #24266 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24266   +/-   ##
=======================================
  Coverage   98.81%   98.81%           
=======================================
  Files         363      363           
  Lines        7281     7281           
  Branches     2006     1967   -39     
=======================================
  Hits         7195     7195           
  Misses         86       86

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44cfc35...8c86aee. Read the comment docs.

@xrkffgg xrkffgg requested review from afc163 and zombieJ May 19, 2020 01:50
@yoyo837
Copy link
Contributor

yoyo837 commented May 19, 2020

small size hover “减”的时候"上箭头"好像没有hover “加”的时候“下箭头”位置好。

@zombieJ
Copy link
Member

zombieJ commented May 19, 2020

small size hover “减”的时候"上箭头"好像没有hover “加”的时候“下箭头”位置好。

嗯，不过原本的好像也差不多。这个可以先合了。

@zombieJ zombieJ merged commit 5b61c0f into master May 19, 2020
@zombieJ zombieJ deleted the fix-inputnumber-icon branch May 19, 2020 02:12
@chenshuai2144 chenshuai2144 mentioned this pull request May 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afc163 afc163 Awaiting requested review from afc163

@zombieJ zombieJ Awaiting requested review from zombieJ

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

InputNumer 上下增加按钮错位
4 participants
@xrkffgg @ant-design-bot @yoyo837 @zombieJ